netdev - Re: [PATCH net-next] net/sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Jan 2017 11:08:07 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     yotamg@...lanox.com
Cc:     jhs@...atatu.com, eladr@...lanox.com, jiri@...lanox.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: cls_matchall: Fix error path

From: Yotam Gigi <yotamg@...lanox.com>
Date: Tue,  3 Jan 2017 17:47:02 +0200

> Fix several error paths in matchall:
>  - Release reference to actions in case the hardware fails offloading
>    (relevant to skip_sw only)
>  - Fix error path in case tcf_exts initialization fails
> 
> Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
> Signed-off-by: Yotam Gigi <yotamg@...lanox.com>

Nothing is checking the tcf_exts_init() return value for errors either,
and I think you should fix this alongside these release problems at the
same time.

Thanks.