netdev - Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2017 16:31:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Westphal <fw@...len.de>
Cc:     kbuild-all@...org, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer
 storage area

Hi Florian,

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-skbuff-merge-nfctinfo-bits-and-nfct-pointer/20170105-133727
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-b0-01051551 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/ipv4/netfilter/nf_dup_ipv4.c: In function 'nf_dup_ipv4':
>> net/ipv4/netfilter/nf_dup_ipv4.c:56: warning: unused variable 'untracked'

vim +/untracked +56 net/ipv4/netfilter/nf_dup_ipv4.c

    40		fl4.flowi4_flags = FLOWI_FLAG_KNOWN_NH;
    41		rt = ip_route_output_key(net, &fl4);
    42		if (IS_ERR(rt))
    43			return false;
    44	
    45		skb_dst_drop(skb);
    46		skb_dst_set(skb, &rt->dst);
    47		skb->dev      = rt->dst.dev;
    48		skb->protocol = htons(ETH_P_IP);
    49	
    50		return true;
    51	}
    52	
    53	void nf_dup_ipv4(struct net *net, struct sk_buff *skb, unsigned int hooknum,
    54			 const struct in_addr *gw, int oif)
    55	{
  > 56		struct nf_conn *untracked;
    57		struct iphdr *iph;
    58	
    59		if (this_cpu_read(nf_skb_duplicated))
    60			return;
    61		/*
    62		 * Copy the skb, and route the copy. Will later return %XT_CONTINUE for
    63		 * the original skb, which should continue on its way as if nothing has
    64		 * happened. The copy should be independently delivered to the gateway.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28934 bytes)