netdev - Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2017 14:23:02 -0800
From:   David VomLehn <vomlehn@...as.net>
To:     David Miller <davem@...emloft.net>,
        Alexander.Loktionov@...antia.com
Cc:     netdev@...r.kernel.org, Simon.Edelhaus@...antia.com,
        Dmitrii.Tarakanov@...antia.com, Pavel.Belous@...antia.com
Subject: Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC
 driver

On 01/06/2017 01:02 PM, David Miller wrote:
> From: Alexander Loktionov <Alexander.Loktionov@...antia.com>
> Date: Fri,  6 Jan 2017 00:06:01 -0800
>
>> This series introduced the AQtion NIC driver for the aQuantia
>> AQC107/AQC108 network devices.
>>
>> v1: Initial version
>> v2: o Make necessary drivers/net/ethernet changes to integrate software
>>      o Drop intermediate atlantic directory
>>      o Remove Makefile things only appropriate to out of tree module builidng
> Every patch series must be fully bisectable, this means that at each step
> of the series, the kernel tree must fully build and work properly.
>
> You break that already at the first patch, which makes the Kconfig options
> available, which if enabled will cause a build failure.
>
> make[4]: *** No rule to make target 'drivers/net/ethernet/aquantia/aq_main.o', needed by 'drivers/net/ethernet/aquantia/atlantic.o'.  Stop.
> make[4]: *** Waiting for unfinished jobs....
> scripts/Makefile.build:551: recipe for target 'drivers/net/ethernet/aquantia' failed
> make[3]: *** [drivers/net/ethernet/aquantia] Error 2
> make[3]: *** Waiting for unfinished jobs....
> scripts/Makefile.build:551: recipe for target 'drivers/net/ethernet' failed
> make[2]: *** [drivers/net/ethernet] Error 2
> scripts/Makefile.build:551: recipe for target 'drivers/net' failed
> make[1]: *** [drivers/net] Error 2
> make[1]: *** Waiting for unfinished jobs....
> Makefile:988: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
> The way to do this, is to add the pieces of source code infrastrucutre,
> one piece at a time.  And then at the very very end, enable the code
> into the build.

Thanks, will fix shortly.

-- 
David VL