netdev - Re: [PATCHv1 1/7] TAP: Refactoring macvtap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Jan 2017 01:12:38 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sainath Grandhi <sainath.grandhi@...el.com>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>, mahesh@...dewar.net,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv1 1/7] TAP: Refactoring macvtap.c

On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi
<sainath.grandhi@...el.com> wrote:
> macvtap module has code for tap/queue management and link management. This patch splits
> the code into macvtap_main.c for link management and tap.c for tap/queue management.
> Functionality in tap.c can be re-used for implementing tap on other virtual interfaces.
>
> Signed-off-by: Sainath Grandhi <sainath.grandhi@...el.com>
> Tested-by: Sainath Grandhi <sainath.grandhi@...el.com>
> ---
>  drivers/net/Makefile       |    2 +
>  drivers/net/macvtap.c      | 1374 --------------------------------------------
>  drivers/net/macvtap_main.c |  218 +++++++
>  drivers/net/tap.c          | 1186 ++++++++++++++++++++++++++++++++++++++
>  include/linux/if_macvtap.h |   10 +
>  5 files changed, 1416 insertions(+), 1374 deletions(-)
>  delete mode 100644 drivers/net/macvtap.c
>  create mode 100644 drivers/net/macvtap_main.c
>  create mode 100644 drivers/net/tap.c
>  create mode 100644 include/linux/if_macvtap.h

Can you use -M -C for better view of this change? It's really hard to review.


-- 
With Best Regards,
Andy Shevchenko