netdev - Re: [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2017 11:24:45 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Cc:     Alexander Duyck <alexander.h.duyck@...el.com>,
        John Fastabend <john.r.fastabend@...el.com>,
        Anjali Singhai Jain <anjali.singhai@...el.com>,
        jakub.kicinski@...ronome.com, intel-wired-lan@...ts.osuosl.org,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode.

On Fri, Jan 6, 2017 at 12:32 AM, Samudrala, Sridhar
<sridhar.samudrala@...el.com> wrote:
> On 1/5/2017 3:50 AM, Or Gerlitz wrote:

> It looks like you are returning the VF port number as phys_port_name() for a
> VF rep in en_rep.c. Is this correct?

yeah, correct, what we all call the VF rep actually represents the
eswitch vport the VF is connected to. The most flexible input for user
space would be just to get this port number along with the switchdev
ID which tells them to which switch this port belongs.

> By default i am creating VFPR netdev with name as <pf_name>_VF<vf_num>
> For ex; if enp5s0f0 is the pf name, VFPR netdev for VF0 will be enp5s0f0_vf0
>
> If we want udev to follow this syntax should i return '_vf0'  as
> get_phys_port_name() for VF rep 0?

just return a number. Typically the PF is vport #0, so for vf0 you
would return 1, this is aligned with the kernel switchdev
documentation [1]

Or.

[1] http://lxr.free-electrons.com/source/Documentation/networking/switchdev.txt#L104