netdev - Re: [for-next V2 06/10] net/mlx5: Add interface to get reference to a UAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 10:31:36 +0200
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Yuval Shaia <yuval.shaia@...cle.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Doug Ledford <dledford@...hat.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        linux-rdma@...r.kernel.org, Leon Romanovsky <leonro@...lanox.com>,
        Eli Cohen <eli@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [for-next V2 06/10] net/mlx5: Add interface to get reference to a UAR

On Sun, Jan 8, 2017 at 7:05 PM, Yuval Shaia <yuval.shaia@...cle.com> wrote:
> On Sun, Jan 08, 2017 at 05:54:47PM +0200, Saeed Mahameed wrote:
>> From: Eli Cohen <eli@...lanox.com>
>>
>>       err = mlx5_create_map_eq(dev, &table->cmd_eq, MLX5_EQ_VEC_CMD,
>>                                MLX5_NUM_CMD_EQE, 1ull << MLX5_EVENT_TYPE_CMD,
>> -                              "mlx5_cmd_eq", &dev->priv.bfregi.uars[0],
>> -                              MLX5_EQ_TYPE_ASYNC);
>> +                              "mlx5_cmd_eq",  MLX5_EQ_TYPE_ASYNC);
>
> Remove extra space
>

Hi Yuval, thanks for the review,
We will submit an incremental patch for this, as checkpatch doesn't
complain about such minor things.