netdev - Re: [PATCH net-next] bpf: Make unnecessarily global functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2017 21:01:43 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     netdev@...r.kernel.org, ast@...nel.org, kafai@...com
Subject: Re: [PATCH net-next] bpf: Make unnecessarily global functions
 static

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Tue, 10 Jan 2017 15:02:16 +0100

> Make the functions __local_list_pop_free(), __local_list_pop_pending(),
> bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they
> are not used outide of bpf_lru_list.c
> 
> This fixes the following GCC warnings when building with 'W=1':
> 
>   kernel/bpf/bpf_lru_list.c:363:22: warning: no previous prototype for ‘__local_list_pop_free’ [-Wmissing-prototypes]
>   kernel/bpf/bpf_lru_list.c:376:22: warning: no previous prototype for ‘__local_list_pop_pending’ [-Wmissing-prototypes]
>   kernel/bpf/bpf_lru_list.c:560:6: warning: no previous prototype for ‘bpf_common_lru_populate’ [-Wmissing-prototypes]
>   kernel/bpf/bpf_lru_list.c:577:6: warning: no previous prototype for ‘bpf_percpu_lru_populate’ [-Wmissing-prototypes]
> 
> Cc: Martin KaFai Lau <kafai@...com>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied.