netdev - Re: [PATCH] net/irda: fix lockdep annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Jan 2017 15:52:03 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Dave Jones <davej@...hat.com>,
        Samuel Ortiz <samuel@...tiz.org>,
        David Miller <davem@...emloft.net>,
        Alexander Potapenko <glider@...gle.com>,
        andreyknvl <andreyknvl@...gle.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net/irda: fix lockdep annotation

On Mon, Jan 16, 2017 at 3:11 PM, kbuild test robot <lkp@...el.com> wrote:
> Hi Dmitry,
>
> [auto build test WARNING on net-next/master]
> [also build test WARNING on v4.10-rc4 next-20170116]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Dmitry-Vyukov/net-irda-fix-lockdep-annotation/20170116-183405
> config: x86_64-randconfig-s2-01161850 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
>    net/irda/irqueue.c: In function 'hashbin_delete':
>>> net/irda/irqueue.c:393: warning: unused variable 'depth'


Mailed v2 with a fix for the warning.

Thanks, 0-DAY!


>    At top level:
>    cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized"
>
> vim +/depth +393 net/irda/irqueue.c
>
>    377
>    378
>    379  /*
>    380   * Function hashbin_delete (hashbin, free_func)
>    381   *
>    382   *    Destroy hashbin, the free_func can be a user supplied special routine
>    383   *    for deallocating this structure if it's complex. If not the user can
>    384   *    just supply kfree, which should take care of the job.
>    385   */
>    386  #ifdef CONFIG_LOCKDEP
>    387  static atomic_t hashbin_lock_depth = ATOMIC_INIT(0);
>    388  #endif
>    389  int hashbin_delete( hashbin_t* hashbin, FREE_FUNC free_func)
>    390  {
>    391          irda_queue_t* queue;
>    392          unsigned long flags = 0;
>  > 393          int i, depth = 0;
>    394
>    395          IRDA_ASSERT(hashbin != NULL, return -1;);
>    396          IRDA_ASSERT(hashbin->magic == HB_MAGIC, return -1;);
>    397
>    398          /* Synchronize */
>    399          if ( hashbin->hb_type & HB_LOCK ) {
>    400  #ifdef CONFIG_LOCKDEP
>    401                  depth = atomic_inc_return(&hashbin_lock_depth) - 1;
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation