netdev - Re: [PATCH] ip/xfrm: Fix deleteall when having many policies installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jan 2017 08:44:12 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Alexander Heinlein <alexander.heinlein@...unet.com>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH] ip/xfrm: Fix deleteall when having many policies
 installed

On Mon, 16 Jan 2017 15:09:01 +0100
Alexander Heinlein <alexander.heinlein@...unet.com> wrote:

> Fix "Policy buffer overflow" error when trying to use deleteall with
> many policies installed.
> 
> Signed-off-by: Alexander Heinlein <alexander.heinlein@...unet.com>
> ---
>  ip/xfrm_policy.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ip/xfrm_policy.c b/ip/xfrm_policy.c
> index cc9c0f1..451b982 100644
> --- a/ip/xfrm_policy.c
> +++ b/ip/xfrm_policy.c
> @@ -732,10 +732,8 @@ static int xfrm_policy_keep(const struct
> sockaddr_nl *who,
>  	if (!xfrm_policy_filter_match(xpinfo, ptype))
>  		return 0;
> 
> -	if (xb->offset > xb->size) {
> -		fprintf(stderr, "Policy buffer overflow\n");
> -		return -1;
> -	}
> +	if (xb->offset + NLMSG_LENGTH(sizeof(*xpid)) > xb->size)
> +		return 0;
> 
>  	new_n = (struct nlmsghdr *)(xb->buf + xb->offset);
>  	new_n->nlmsg_len = NLMSG_LENGTH(sizeof(*xpid));


What happens when many many policies are installed?
It looks like your patch would silently stop deleting.
Does the the code flush all of them?