netdev - Re: [PATCH net-next v4 2/2] net sched: Trivial whitespace and stylistic changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jan 2017 11:30:55 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jiri@...lanox.com,
        paulb@...lanox.com, john.fastabend@...il.com,
        simon.horman@...ronome.com, mrv@...atatu.com, hadarh@...lanox.com,
        ogerlitz@...lanox.com, roid@...lanox.com, xiyou.wangcong@...il.com,
        daniel@...earbox.net
Subject: Re: [PATCH net-next v4 2/2] net sched: Trivial whitespace and
 stylistic changes


Jiri,

I am going to drop this patch altogether. Someday i will do the cleanup.

cheers,
jamal

On 17-01-17 07:12 AM, Jiri Pirko wrote:
> Tue, Jan 17, 2017 at 12:11:49PM CET, jhs@...atatu.com wrote:
>> From: Jamal Hadi Salim <jhs@...atatu.com>
>>
>> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>
>> ---
>
> [...]
> 	
>> -static inline unsigned long
>> -cls_set_class(struct tcf_proto *tp, unsigned long *clp,
>> +static inline unsigned long cls_set_class(struct tcf_proto *tp,
>> +					  unsigned long *clp,
>> 	unsigned long cl)
>
> While you are at it, you can align this as well.
>
>
>> {
>> 	unsigned long old_cl;
>> -	
>
> This empty line should definitelly stay.
>
>
>> 	tcf_tree_lock(tp);
>> 	old_cl = __cls_set_class(clp, cl);
>> 	tcf_tree_unlock(tp);
>> -
>> 	return old_cl;
>> }
>>
>
> [...]
>
>> @@ -237,7 +232,6 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result)
>>
>> 	return 0;
>> }
>> -	
>
> This empty line should stay.
>
>
>> /**
>>  * struct tcf_ematch_tree - ematch tree handle
>>  *
>> @@ -246,8 +240,7 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result)
>>  */
>> struct tcf_ematch_tree {
>> 	struct tcf_ematch_tree_hdr hdr;
>> -	struct tcf_ematch *	matches;
>> -	
>> +	struct tcf_ematch	*matches;
>
> Well, to be pedantic, this still looks odd :)
>
>
>> };