netdev - Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79c6ecce-bfcb-ebaa-afd2-05c1d86004d7@amazon.com>
Date:   Wed, 18 Jan 2017 09:02:17 -0800
From:   Vineeth Remanan Pillai <vineethp@...zon.com>
To:     Juergen Gross <jgross@...e.com>,
        David Miller <davem@...emloft.net>,
        <boris.ostrovsky@...cle.com>, <xen-devel@...ts.xenproject.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <kamatam@...zon.com>, <aliguori@...zon.com>, <vineethp@...zon.com>
Subject: Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and
 OOM


On 01/15/2017 10:24 PM, Juergen Gross wrote:
> On 13/01/17 18:55, Remanan Pillai wrote:
>> From: Vineeth Remanan Pillai <vineethp@...zon.com>
>>
>> During an OOM scenario, request slots could not be created as skb
>> allocation fails. So the netback cannot pass in packets and netfront
>> wrongly assumes that there is no more work to be done and it disables
>> polling. This causes Rx to stall.
>>
>> The issue is with the retry logic which schedules the timer if the
>> created slots are less than NET_RX_SLOTS_MIN. The count of new request
>> slots to be pushed are calculated as a difference between new req_prod
>> and rsp_cons which could be more than the actual slots, if there are
>> unconsumed responses.
>>
>> The fix is to calculate the count of newly created slots as the
>> difference between new req_prod and old req_prod.
>>
>> Signed-off-by: Vineeth Remanan Pillai <vineethp@...zon.com>
> Reviewed-by: Juergen Gross <jgross@...e.com>
Thanks Juergen.

David,

Could you please pick up this change for net-next if there no more 
concerns..

Many Thanks,
Vineeth

>
>
> Thanks,
>
> Juergen
>