netdev - Re: [PATCH] net/mlx5e: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2017 11:44:23 +0200
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Gal Pressman <galp@...lanox.com>,
        Maor Gottlieb <maorg@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Remove unused variable

Hi Arnd,

On 19/01/2017 11:33 AM, Arnd Bergmann wrote:
> A cleanup removed the only user of this variable
>
> mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels':
> mlx5/core/en_ethtool.c:546:6: error: unused variable 'ncv' [-Werror=unused-variable]
>
> Let's remove the declaration as well.
>
> Fixes: 639e9e94160e ("net/mlx5e: Remove unnecessary checks when setting num channels")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> index b1b9eb6ee135..5197817e4b2f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> @@ -543,7 +543,6 @@ static int mlx5e_set_channels(struct net_device *dev,
>   			      struct ethtool_channels *ch)
>   {
>   	struct mlx5e_priv *priv = netdev_priv(dev);
> -	int ncv = mlx5e_get_max_num_channels(priv->mdev);
>   	unsigned int count = ch->combined_count;
>   	bool arfs_enabled;
>   	bool was_opened;
Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Thanks for the fix!

Regards,
Tariq