netdev - Re: [PATCH V2 1/3] net: bgmac: allocate struct bgmac just once & don't copy it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Jan 2017 07:40:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        Jon Mason <jon.mason@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Felix Fietkau <nbd@...nwrt.org>, netdev@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH V2 1/3] net: bgmac: allocate struct bgmac just once &
 don't copy it

Hi Rafał,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.10-rc5 next-20170125]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/net-next-use-one-struct-bgmac-add-PHY-support/20170129-062241
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bgmac.c: In function 'bgmac_alloc':
>> drivers/net/ethernet/broadcom/bgmac.c:1455:12: error: implicit declaration of function 'devm_alloc_etherdev' [-Werror=implicit-function-declaration]
     net_dev = devm_alloc_etherdev(dev, sizeof(*bgmac));
               ^~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/broadcom/bgmac.c:1455:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     net_dev = devm_alloc_etherdev(dev, sizeof(*bgmac));
             ^
   cc1: some warnings being treated as errors

vim +/devm_alloc_etherdev +1455 drivers/net/ethernet/broadcom/bgmac.c

  1449	struct bgmac *bgmac_alloc(struct device *dev)
  1450	{
  1451		struct net_device *net_dev;
  1452		struct bgmac *bgmac;
  1453	
  1454		/* Allocation and references */
> 1455		net_dev = devm_alloc_etherdev(dev, sizeof(*bgmac));
  1456		if (!net_dev)
  1457			return NULL;
  1458	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57922 bytes)