netdev - Re: [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 19:13:02 +0300
From:   Pavel Belous <pavel.s.belous@...il.com>
To:     tremyfr@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link_ksettings

Hi Philippe,

thanks you for your patch, it looks good.
One improvement - could you please add support/advertising for TP?

>+	supported |= SUPPORTED_Autoneg;
need:
	supported |= SUPPORTED_TP;


>+	advertising = (self->aq_nic_cfg.is_autoneg) ?
> 							ADVERTISED_Autoneg : 0U;

need:
	advertising |= ADVERTISED_TP;


Thank you.