[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 2 Feb 2017 17:44:57 +0100
From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To: Russell King - ARM Linux <linux@...linux.org.uk>
Cc: Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
Yehuda Yitschak <yehuday@...vell.com>,
Jason Cooper <jason@...edaemon.net>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
netdev@...r.kernel.org, Hanna Hawa <hannah@...vell.com>,
Nadav Haklai <nadavh@...vell.com>,
Rob Herring <robh+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Kumar Gala <galak@...eaurora.org>,
Gregory Clement <gregory.clement@...e-electrons.com>,
Stefan Chulski <stefanc@...vell.com>,
Marcin Wojtas <mw@...ihalf.com>,
"David S. Miller" <davem@...emloft.net>,
linux-arm-kernel@...ts.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2
binding for PPv2.2 support
Hello,
On Sat, 7 Jan 2017 09:32:28 +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 28, 2016 at 05:46:17PM +0100, Thomas Petazzoni wrote:
> > @@ -31,7 +43,7 @@ Optional properties (port):
> > then fixed link is assumed, and the 'fixed-link' property is
> > mandatory.
>
> Not directly related to this patch, but this context is wrong. The
> PP2 driver _requires_ a PHY. It doesn't support fixed-link in its
> current form. I think the DT binding describes an expectation of
> a future driver.
>
> The side effect is that if trying to use a fixed-link on any port,
> the ethernet driver fails to probe.
Correct. I will send a patch to adjust the Device Tree binding
documentation accordingly. Thanks for noticing this mistake!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Powered by blists - more mailing lists