netdev - Re: [PATCH net-next] net: skb_needs_check() accepts CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 03 Feb 2017 17:33:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, maze@...gle.com,
        edumazet@...gle.com, dvyukov@...gle.com
Subject: Re: [PATCH net-next] net: skb_needs_check() accepts CHECKSUM_NONE
 for tx

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 03 Feb 2017 14:29:42 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> My recent change missed fact that UFO would perform a complete
> UDP checksum before segmenting in frags.
> 
> In this case skb->ip_summed is set to CHECKSUM_NONE.
> 
> We need to add this valid case to skb_needs_check()
> 
> Fixes: b2504a5dbef3 ("net: reduce skb_warn_bad_offload() noise")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.