netdev - Re: [PATCH net-next] virtio_net: exploit napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 04 Feb 2017 19:39:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, jasowang@...hat.com, mst@...hat.com,
        willemb@...gle.com
Subject: Re: [PATCH net-next] virtio_net: exploit napi_complete_done()
 return value

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 04 Feb 2017 07:49:21 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Since commit 364b6055738b ("net: busy-poll: return busypolling status to
> drivers"), napi_complete_done() returns a boolean that can be used
> by drivers to conditionally rearm interrupts.
> 
> This patch changes virtio_net to use this boolean to avoid a bit of
> overhead for busy-poll users.
> 
> Jason reports about 1.1% improvement for 1 byte TCP_RR (burst 100).
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Jason Wang <jasowang@...hat.com>

Applied.