netdev - [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  7 Feb 2017 15:03:02 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org, linux-mips@...ux-mips.org,
        linux-nfs@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
        target-devel@...r.kernel.org
Cc:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Anna Schumaker <anna.schumaker@...app.com>,
        "David S. Miller" <davem@...emloft.net>,
        Derek Chickles <derek.chickles@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        Jeff Layton <jlayton@...chiereds.net>,
        Jiri Slaby <jirislaby@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "Luis R. Rodriguez" <mcgrof@...not-panic.com>,
        Madalin Bucur <madalin.bucur@....com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Nicolas Ferre <nicolas.ferre@...el.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Timur Tabi <timur@...eaurora.org>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()

From: Russell King <rmk+kernel@...linux.org.uk>

octeon-platform.c can not be built as a module for two reasons:

(a) the Makefile doesn't allow it:
    obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o

(b) the multiple *_initcall() statements, each of which are translated
    to a module_init() call when attempting a module build, become
    aliases to init_module().  Having more than one alias will cause a
    build error.

Hence, rather than adding a linux/module.h include, remove the redundant
MODULE_*() from this file.

Acked-by: David Daney <david.daney@...ium.com>
Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 37a932d9148c..8297ce714c5e 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -1060,7 +1060,3 @@ static int __init octeon_publish_devices(void)
 	return of_platform_bus_probe(NULL, octeon_ids, NULL);
 }
 arch_initcall(octeon_publish_devices);
-
-MODULE_AUTHOR("David Daney <ddaney@...iumnetworks.com>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Platform driver for Octeon SOC");
-- 
2.9.3