netdev - Re: [PATCH net-next 4/9] mlx4: get rid of frag_prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2017 06:06:33 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Martin KaFai Lau <kafai@...com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Brenden Blanco <bblanco@...mgrid.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 4/9] mlx4: get rid of frag_prefix_size

On Thu, Feb 9, 2017 at 4:28 AM, Tariq Toukan <ttoukan.linux@...il.com> wrote:
>
>
> On 07/02/2017 5:02 AM, Eric Dumazet wrote:
>>

>> +       for (nr = 0;;) {
>> +               frag_size = min_t(int, length, frag_info->frag_size);
>> +
>>                 if (unlikely(!frags[nr].page))
>>                         goto fail;
>>   @@ -603,15 +602,16 @@ static int mlx4_en_complete_rx_desc(struct
>> mlx4_en_priv *priv,
>>                 __skb_fill_page_desc(skb, nr, frags[nr].page,
>>                                      frags[nr].page_offset,
>> -                                    frag_info->frag_size);
>> +                                    frag_size);
>
> Same for dma_sync_single (two lines above).

Oh right, although I was not sure it this really matter on a part of a page.