netdev - Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2017 16:22:08 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Shannon Nelson <shannon.nelson@...cle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool
 support

On Fri, 10 Feb 2017 09:38:20 -0800
Shannon Nelson <shannon.nelson@...cle.com> wrote:

> +static void vsw_get_ethtool_stats(struct net_device *dev,
> +				  struct ethtool_stats *estats, u64 *data)
> +{
> +	int i = 0;
> +
> +	data[i++] = dev->stats.rx_packets;
> +	data[i++] = dev->stats.tx_packets;
> +	data[i++] = dev->stats.rx_bytes;
> +	data[i++] = dev->stats.tx_bytes;
> +	data[i++] = dev->stats.rx_errors;
> +	data[i++] = dev->stats.tx_errors;
> +	data[i++] = dev->stats.rx_dropped;
> +	data[i++] = dev->stats.tx_dropped;
> +	data[i++] = dev->stats.multicast;

Please do not duplicate regular network statistics into ethtool.
This doesn't really add any value.