netdev - Re: [PATCH net] packet: Do not call fanout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2017 06:26:04 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Anoob Soman <anoob.soman@...rix.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] packet: Do not call fanout_release from atomic
 contexts

On Mon, 2017-02-13 at 13:28 +0000, Anoob Soman wrote:

> Wouldn't it be easier to call synchronize_net(), before calling 
> fanout_release_data() and kfree(f).
> The behavior, wrt synchronize_net, would be same as before and 
> fanout_release() will cleanup everything without leaving any residue.

So we would require two synchronize_net() calls instead of one ?

synchronize_net() is very expensive on some hosts, it is a big hammer.