netdev - Re: [PATCH 2/3] net: stmicro: prepare dwmac4 dma for mtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2017 06:37:27 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     kbuild-all@...org, davem@...emloft.net, peppe.cavallaro@...com,
        alexandre.torgue@...com, netdev@...r.kernel.org,
        Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH 2/3] net: stmicro: prepare dwmac4 dma for mtl

Hi Joao,

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20170214]
[cannot apply to v4.10-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joao-Pinto/add-support-for-multiple-queues-channels-in-stmmac/20170215-024621
config: i386-randconfig-x002-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_hw_setup':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1932:3: warning: 'dummy_dma_rx_phy' may be used uninitialized in this function [-Wmaybe-uninitialized]
      priv->hw->dma->init(priv->ioaddr, priv->plat->dma_cfg,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            dummy_dma_tx_phy, dummy_dma_rx_phy, atds);
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1909:6: note: 'dummy_dma_rx_phy' was declared here
     u32 dummy_dma_rx_phy, dummy_dma_tx_phy = 0;
         ^~~~~~~~~~~~~~~~

vim +/dummy_dma_rx_phy +1932 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

a332e2fa Niklas Cassel      2016-12-07  1916  	if (!priv->plat->dma_cfg || !priv->plat->dma_cfg->pbl) {
a332e2fa Niklas Cassel      2016-12-07  1917  		dev_err(priv->device, "Invalid DMA configuration\n");
89ab75bf Niklas Cassel      2016-12-07  1918  		return -EINVAL;
0f1f88a8 Giuseppe CAVALLARO 2012-04-18  1919  	}
0f1f88a8 Giuseppe CAVALLARO 2012-04-18  1920  
c24602ef Giuseppe CAVALLARO 2013-03-26  1921  	if (priv->extend_desc && (priv->mode == STMMAC_RING_MODE))
c24602ef Giuseppe CAVALLARO 2013-03-26  1922  		atds = 1;
c24602ef Giuseppe CAVALLARO 2013-03-26  1923  
495db273 Giuseppe Cavallaro 2016-02-29  1924  	ret = priv->hw->dma->reset(priv->ioaddr);
495db273 Giuseppe Cavallaro 2016-02-29  1925  	if (ret) {
495db273 Giuseppe Cavallaro 2016-02-29  1926  		dev_err(priv->device, "Failed to reset the dma\n");
495db273 Giuseppe Cavallaro 2016-02-29  1927  		return ret;
495db273 Giuseppe Cavallaro 2016-02-29  1928  	}
495db273 Giuseppe Cavallaro 2016-02-29  1929  
5047d338 Joao Pinto         2017-02-14  1930  	if (priv->synopsys_id >= DWMAC_CORE_4_00) {
5047d338 Joao Pinto         2017-02-14  1931  		/* DMA Configuration */
50ca903a Niklas Cassel      2016-12-07 @1932  		priv->hw->dma->init(priv->ioaddr, priv->plat->dma_cfg,
5047d338 Joao Pinto         2017-02-14  1933  				    dummy_dma_tx_phy, dummy_dma_rx_phy, atds);
5047d338 Joao Pinto         2017-02-14  1934  
5047d338 Joao Pinto         2017-02-14  1935  		/* DMA RX Channel Configuration */
5047d338 Joao Pinto         2017-02-14  1936  		for (chan = 0; chan < rx_channels_count; chan++) {
5047d338 Joao Pinto         2017-02-14  1937  			priv->hw->dma->init_rx_chan(priv->ioaddr,
5047d338 Joao Pinto         2017-02-14  1938  						    priv->plat->dma_cfg,
5047d338 Joao Pinto         2017-02-14  1939  						    priv->dma_rx_phy, chan);
afea0365 Giuseppe Cavallaro 2016-02-29  1940  

:::::: The code at line 1932 was first introduced by commit
:::::: 50ca903afc2a4ccf7efd25744577fecb0ce6fb49 net: stmmac: simplify the common DMA init API

:::::: TO: Niklas Cassel <niklas.cassel@...s.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32175 bytes)