netdev - Re: [PATCH net-next 04/13] net: ethernet: aquantia: Using module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2017 21:57:11 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Pavel Belous <Pavel.Belous@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Alexey Andriyanov <Alexey.Andriyanov@...antia.com>
Subject: Re: [PATCH net-next 04/13] net: ethernet: aquantia: Using
 module_pci_driver.

On 15.02.2017 21:01, Pavel Belous wrote:
> From: Pavel Belous <pavel.belous@...antia.com>
>
> Remove boilerplate code by using macro module_pci_driver.
>
> Signed-off-by: Pavel Belous <pavel.belous@...antia.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> index e5539c8..f7513cb 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> @@ -250,22 +250,4 @@ static struct pci_driver aq_pci_ops = {
>  	.resume = aq_pci_resume,
>  };
>
> -static int __init aq_module_init(void)
> -{
> -	int err = 0;
> -
> -	err = pci_register_driver(&aq_pci_ops);
> -	if (err < 0)
> -		goto err_exit;
> -
> -err_exit:
> -	return err;
> -}
> -
> -static void __exit aq_module_exit(void)
> -{
> -	pci_unregister_driver(&aq_pci_ops);
> -}
> -
> -module_init(aq_module_init);
> -module_exit(aq_module_exit);
> +module_pci_driver(aq_pci_ops);
>

Reviewed-by: Lino Sanfilippo <LinoSanfilippo@....de>

Regards,
Lino