lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Feb 2017 07:49:38 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Arnd Bergmann <arnd@...db.de> Cc: Stanislaw Gruszka <sgruszka@...hat.com>, Helmut Schaa <helmut.schaa@...glemail.com>, Mathias Kresin <dev@...sin.me>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rt2500usb: don't mark register accesses as inline Arnd Bergmann <arnd@...db.de> writes: > When CONFIG_KASAN is set, we get a rather large stack here: > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function 'rt2500usb_set_device_state': > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size of 3032 bytes is larger than 100 bytes [-Werror=frame-larger-than=] > > If we don't force those functions to be inline, the compiler can figure this > out better itself and not inline the functions when doing so would be harmful, > reducing the stack size to a merge 256 bytes. > > Note that there is another problem that manifests in this driver, as a result > of the typecheck() macro causing even larger stack frames. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> [...] > -static inline void rt2500usb_register_multiread(struct rt2x00_dev *rt2x00dev, > - const unsigned int offset, > - void *value, const u16 length) > -{ > - rt2x00usb_vendor_request_buff(rt2x00dev, USB_MULTI_READ, > - USB_VENDOR_REQUEST_IN, offset, > - value, length); > -} > - I guess you removed this because it was not actually used anywhere? Just checking. -- Kalle Valo
Powered by blists - more mailing lists