netdev - Re: [PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2017 08:59:25 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Marcus Huewe <suse-tux@....de>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: neigh: Fix netevent
 NETEVENT_DELAY_PROBE_TIME_UPDATE notification

On Wed, Feb 15, 2017 at 01:00:36AM +0100, Marcus Huewe wrote:
> When setting a neigh related sysctl parameter, we always send a
> NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when
> executing
> 
> 	sysctl net.ipv6.neigh.wlp3s0.retrans_time_ms=2000
> 
> a NETEVENT_DELAY_PROBE_TIME_UPDATE netevent is generated.
> 
> This is caused by commit 2a4501ae18b5 ("neigh: Send a
> notification when DELAY_PROBE_TIME changes"). According to the
> commit's description, it was intended to generate such an event
> when setting the "delay_first_probe_time" sysctl parameter.
> 
> In order to fix this, only generate this event when actually
> setting the "delay_first_probe_time" sysctl parameter. This fix
> should not have any unintended side-effects, because all but one
> registered netevent callbacks check for other netevent event
> types (the registered callbacks were obtained by grepping for
> "register_netevent_notifier"). The only callback that uses the
> NETEVENT_DELAY_PROBE_TIME_UPDATE event is
> mlxsw_sp_router_netevent_event() (in
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c): in case
> of this event, it only accesses the DELAY_PROBE_TIME of the
> passed neigh_parms.
> 
> Signed-off-by: Marcus Huewe <suse-tux@....de>

Fixes: 2a4501ae18b5 ("neigh: Send a notification when DELAY_PROBE_TIME changes")
Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Next time, please Cc the author of the commit you're referring to in
your patch.

Thanks!