netdev - RE: [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 13:10:06 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Lino Sanfilippo' <LinoSanfilippo@....de>,
        Pavel Belous <Pavel.Belous@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Alexey Andriyanov <Alexey.Andriyanov@...antia.com>
Subject: RE: [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring
 buffers copying.

From: Lino Sanfilippo
> Sent: 15 February 2017 21:31
...
> Well, you should really try to avoid copying the tx buffers _at all_.
> E.g. by passing self->buff_ring to aq_ring_tx_append_buffs() instead of
> the temporary array.

Copying can help for horridly fragmented frames or when iommu (etc)
setup is expensive.
At least some ethernet hardware has minimum fragment lengths.

However, if the frame doesn't fit at the end - just copy to the front.

Something should ensure the copies are aligned (you may want gaps
between frames.)

I presume there is a 'space in buffer' check elsewhere.

	David