netdev - Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 12:50:25 -0500
From:   Chuck Lever <chuck.lever@...cle.com>
To:     Sagi Grimberg <sagi@...mberg.me>
Cc:     linux-nvme@...ts.infradead.org,
        List Linux RDMA Mailing <linux-rdma@...r.kernel.org>,
        target-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address


> On Feb 16, 2017, at 12:43 PM, Sagi Grimberg <sagi@...mberg.me> wrote:
> 
> We have some places in the stack that support ipv4 and ipv6. In
> some cases the user configuration does not reveal which
> address family is given and needs to be parsed from the input string.
> 
> Given that the user-input varies between subsystems, some processing
> is required from the call-site to separate address and port strings.
> 
> As a side-effect, this set adds ipv6 support for nvme over fabrics.
> I also converted iscsi target and plan to convert nfs/cifs next but
> wanted to get some feedback before doing that.

At least NFS/RDMA already supports IPv6. You might not need many
changes there, but I'll hold off on further comments.


> patch #1 is based off roland's patch:
> http://lists.infradead.org/pipermail/linux-nvme/2016-August/005600.html
> 
> Sagi Grimberg (4):
>  net/utils: generic inet_pton_with_scope helper
>  nvmet-rdma: use generic inet_pton_with_scope
>  nvme-rdma: use inet_pton_with_scope helper
>  iscsi-target: use generic inet_pton_with_scope
> 
> drivers/nvme/host/rdma.c                     | 48 ++++-----------
> drivers/nvme/target/rdma.c                   | 42 +++++++++----
> drivers/target/iscsi/iscsi_target_configfs.c | 46 ++++----------
> include/linux/inet.h                         |  6 ++
> net/core/utils.c                             | 91 ++++++++++++++++++++++++++++
> 5 files changed, 151 insertions(+), 82 deletions(-)
> 
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
Chuck Lever