netdev - RE: [PATCH net 1/3] qed: Release CQ resource under lock on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 09:19:42 +0000
From:   "Amrani, Ram" <Ram.Amrani@...ium.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     Yuval Shaia <yuval.shaia@...cle.com>,
        "Mintz, Yuval" <Yuval.Mintz@...ium.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "Kalderon, Michal" <Michal.Kalderon@...ium.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>
Subject: RE: [PATCH net 1/3] qed: Release CQ resource under lock on failure

> The bitmap functions are being used by various bitmaps one of which is the cid.
> The cid code must allocate two consecutive cids. So here the lock is over two calls
> to the bit allocating call.
> 
> I am planning to recode the cid to use one bit instead of two, this is further
> down the list.
> 
> Thanks for the suggestion,
> Ram


Hi Dave,
The patches should be taken as is.
The improvement suggestion about the (widely used) mechanism is still under consideration
and will surely not be part of 4.10.

Shall I resend V1?

Thanks,
Ram