netdev - Re: [PATCH net-next] sctp: sctp_transport_dst_check should check if transport pmtu is dst mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Feb 2017 18:19:55 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com,
        vyasevich@...il.com
Subject: Re: [PATCH net-next] sctp: sctp_transport_dst_check should check
 if transport pmtu is dst mtu

From: Xin Long <lucien.xin@...il.com>
Date: Fri, 17 Feb 2017 16:41:45 +0800

> Now when sending a packet, sctp_transport_dst_check will check if dst
> is obsolete by calling ipv4/ip6_dst_check. But they return obsolete
> only when adding a new cache, after that when the cache's pmtu is
> updated again, it will not trigger transport->dst/pmtu's update.
> 
> It can be reproduced by reducing route's pmtu twice. At the 1st time
> client will add a new cache, and transport->pathmtu gets updated as
> sctp_transport_dst_check finds it's obsolete. But at the 2nd time,
> cache's mtu is updated, sctp client will never send out any packet,
> because transport->pmtu has no chance to update.
> 
> This patch is to fix this by also checking if transport pmtu is dst
> mtu in sctp_transport_dst_check, so that transport->pmtu can be
> updated on time.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.