netdev - Re: [PATCH net] Don't allow overwrite of config src addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2017 22:35:20 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Brian Russell <brussell@...cade.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] Don't allow overwrite of config src addr

Hello!

On 02/20/2017 08:03 PM, Brian Russell wrote:

> When using IPv6 transport and a default dst, a pointer to the configured
> source address is passed into the route lookup. If no source address is
> configured, then the value is overwritten.
>
> IPv6 route lookup ignores egress ifindex match if the source adress is set,

    Address. Perhaps can be fixed while applying?

> so if egress ifindex match is desired, the source address must be passed
> as any. The overwrite breaks this for subsequent lookups.
>
> Avoid this by copying the configured address to an existing stack variable
> and pass a pointer to that instead.
>
> Signed-off-by: Brian Russell <brussell@...cade.com>
[...]

MBR, Sergei