netdev - Re: [PATCH next 0/4] bonding: winter cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2017 11:23:13 -0800
From:   Mahesh Bandewar (महेश बंडेवार) 
        <maheshb@...gle.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Mahesh Bandewar <mahesh@...dewar.net>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Veaceslav Falico <vfalico@...il.com>,
        Nikolay Aleksandrov <nikolay@...hat.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH next 0/4] bonding: winter cleanup

On Tue, Feb 21, 2017 at 11:58 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> Wed, Feb 22, 2017 at 02:08:16AM CET, mahesh@...dewar.net wrote:
>>From: Mahesh Bandewar <maheshb@...gle.com>
>>
>>Few cleanup patches that I have accumulated over some time now.
>>
>>(a) First two patches are basically to move the work-queue initialization
>>    from every ndo_open / bond_open operation to once at the beginning while
>>    port creation. Work-queue initialization is an unnecessary operation
>>    for every 'ifup' operation. However we have some mode-specific work-queues
>>    and mode can change anytime after port creation. So the second patch is
>>    to ensure the correct work-handler is called based on the mode.
>>
>>(b) Third patch is simple and straightforward that removes hard-coded value
>>    that was added into the initial commit and replaces it with the default
>>    value configured.
>>
>>(c) The final patch in the series removes the unimplemented "port-moved" state
>>    from the LACP state machine. This state is defined but never set so
>>    removing from the state machine logic makes code little cleaner.
>>
>>Note: None of these patches are making any functional changes.
>>
>>Mahesh Bandewar (4):
>
> Mahesh. I understand that you are still using bonding. What's stopping
> you from using team instead?
>
Let me just say this, if it was trivial enough, we'd have done with it
by now. :)

> Isn't about the time to start deprecate process of bonding? :O
>
>
>>  bonding: restructure arp-monitor
>>  bonding: initialize work-queues during creation of bond
>>  bonding: remove hardcoded value
>>  bonding: remove "port-moved" state that was never implemented
>>
>> drivers/net/bonding/bond_3ad.c  | 11 +++--------
>> drivers/net/bonding/bond_main.c | 42 ++++++++++++++++++++++++++++-------------
>> 2 files changed, 32 insertions(+), 21 deletions(-)
>>
>>--
>>2.11.0.483.g087da7b7c-goog
>>