netdev - Re: [PATCH net-next] net/socket: use per af lockdep classes for sk queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 Mar 2017 09:02:29 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net-next] net/socket: use per af lockdep classes for sk
 queues

On Wed, 2017-03-08 at 17:25 +0100, Paolo Abeni wrote:

>  - no changes, tested with several different workload
> 
> Suggested-by: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  net/core/sock.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 78 insertions(+), 18 deletions(-)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index f6fd79f..b7a3359 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -258,12 +258,66 @@ static const char *const af_family_clock_key_strings[AF_MAX+1] = {
>    "clock-AF_NFC"   , "clock-AF_VSOCK"    , "clock-AF_KCM"      ,
>    "clock-AF_QIPCRTR", "clock-AF_SMC"     , "clock-AF_MAX"
>  };


>  
> +static void sk_init_locks(struct sock *sk)
> +{
> +	skb_queue_head_init(&sk->sk_receive_queue);
> +	skb_queue_head_init(&sk->sk_write_queue);
> +	skb_queue_head_init(&sk->sk_error_queue);
> +
> +	rwlock_init(&sk->sk_callback_lock);
> +	lockdep_set_class_and_name(&sk->sk_receive_queue.lock,
...
> +}

This is minor, but the function name does not really reflect what it
does.

Thanks !