lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Mar 2017 17:57:36 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Doug Berger <opendmb@...il.com> Cc: robh+dt@...nel.org, mark.rutland@....com, davem@...emloft.net, rafal@...ecki.pl, xow@...gle.com, joel@....id.au, jon.mason@...adcom.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, pgynther@...gle.com, jaedon.shin@...il.com Subject: Re: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim On 03/13/2017 05:41 PM, Doug Berger wrote: > The reclaim function should return the number of buffer descriptors > reclaimed, not just the number corresponding to skb packets. > > Also, remove the unnecessary computation when updating the consumer > index. > > While this is not a functional problem it could degrade performance > of napi in a fragmented transmit stream. > > Signed-off-by: Doug Berger <opendmb@...il.com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists