lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Mar 2017 17:37:17 +0200 From: Ido Schimmel <idosch@...sch.org> To: David Ahern <dsa@...ulusnetworks.com> Cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com, shm@...ulusnetworks.com, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, lorenzo@...gle.com, mateusz.bajorski@...ia.com Subject: Re: [patch net-next v2 1/9] net: fib_rules: Check if selector matches all packets On Wed, Mar 15, 2017 at 09:33:14AM -0600, David Ahern wrote: > On 3/15/17 9:30 AM, Ido Schimmel wrote: > >>> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c > >>> index 2892109..7a941a5 100644 > >>> --- a/net/ipv4/fib_rules.c > >>> +++ b/net/ipv4/fib_rules.c > >>> @@ -47,6 +47,16 @@ struct fib4_rule { > >>> #endif > >>> }; > >>> > >>> +bool fib4_rule_matchall(const struct fib_rule *rule) > >>> +{ > >>> + struct fib4_rule *r = (struct fib4_rule *) rule; > >> Use container_of instead of typecast. > > There are multiple conversions from 'fib_rule' to 'fib4_rule' in this > > file, all use typecast. > > understood. dst to rtable/rt6_info has the same problem. Rather than > continuing with the typecast, new code should use container_of and older > code can be converted in time. OK. Will convert the others in follow-up.
Powered by blists - more mailing lists