netdev - [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2017 15:51:27 +0200
From:   Roger Quadros <rogerq@...com>
To:     <f.fainelli@...il.com>, <davem@...emloft.net>
CC:     <andrew@...n.ch>, <kyle.roeschley@...com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Roger Quadros <rogerq@...com>
Subject: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
phy_suspend() doesn't get called as part of phy_stop() for PHYs using
interrupts because the phy state machine is never triggered after a phy_stop().

Explicitly trigger the PHY state machine so that it can
see the new PHY state (HALTED) and suspend the PHY.

Signed-off-by: Roger Quadros <rogerq@...com>
---
 drivers/net/phy/phy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..8fef03b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -903,6 +903,7 @@ void phy_stop(struct phy_device *phydev)
 	 * of rtnl_lock(), but PHY_HALTED shall guarantee phy_change()
 	 * will not reenable interrupts.
 	 */
+	phy_trigger_machine(phydev, true);
 }
 EXPORT_SYMBOL(phy_stop);
 
-- 
2.7.4