lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 15 Mar 2017 15:08:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Roger Quadros <rogerq@...com>
Cc:     f.fainelli@...il.com, davem@...emloft.net, kyle.roeschley@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for
 PHYs with interrupts

On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote:
> Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
> phy_suspend() doesn't get called as part of phy_stop() for PHYs using
> interrupts because the phy state machine is never triggered after a phy_stop().
> 
> Explicitly trigger the PHY state machine so that it can
> see the new PHY state (HALTED) and suspend the PHY.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>

Hi Roger

This seems sensible. It mirrors what phy_start() does.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

It does however lead to a follow up question. Are there other places
phydev->state is changed and it is missing a phy_trigger_machine()?

	      Andrew

Powered by blists - more mailing lists