netdev - Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 19:35:28 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Feng Gao <gfree.wind@...il.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        "David S. Miller" <davem@...emloft.net>, jolsa@...hat.com,
        Netfilter Developer Mailing List 
        <netfilter-devel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when
 snmp_trap_helper fail to register

On 03/20/2017 01:15 PM, Feng Gao wrote:

>>> From: Gao Feng <fgao@...ai8.com>
>>>
>>> In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp
>>
>>
>>    Angle brackets not needed. :-)
>>    The commit citing style is the same as for the Fixes: tag.
>
> The checkpatch.pl reports the following error, if remove the angle brackets.

    Because it stops recognizing the commit ID! :-)

> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("<title line>")' - ie: 'commit fatal: ambig ("evision or path
> not in the working tree.")'

    So check the patch in the correct tree because that seems to be the 
problem... Angle brackets are surely not required.

> #7:
> In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp
>
> total: 1 errors, 0 warnings, 0 checks, 27 lines checked
>
>
> Regards
> Feng

[...]

MBR, Sergei