netdev - Re: [PATCH v3 net 2/5] net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2017 08:13:06 -0400
From:   David Arcari <darcari@...hat.com>
To:     Pavel Belous <Pavel.Belous@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>
Subject: Re: [PATCH v3 net 2/5] net:ethernet:aquantia: Fix packet type
 detection (TCP/UDP) for IPv6.

On 03/23/2017 07:19 AM, Pavel Belous wrote:
> From: Pavel Belous <pavel.belous@...antia.com>
> 
> In order for the checksum offloads to work correctly we need to set the
> packet type bit (TCP/UDP) in the TX context buffer.
> 
> Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific code")
> 
> Signed-off-by: Pavel Belous <pavel.belous@...antia.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index ee78444..db2b51d 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -510,10 +510,22 @@ static unsigned int aq_nic_map_skb(struct aq_nic_s *self,
>  	if (skb->ip_summed == CHECKSUM_PARTIAL) {
>  		dx_buff->is_ip_cso = (htons(ETH_P_IP) == skb->protocol) ?
>  			1U : 0U;
> -		dx_buff->is_tcp_cso =
> -			(ip_hdr(skb)->protocol == IPPROTO_TCP) ? 1U : 0U;
> -		dx_buff->is_udp_cso =
> -			(ip_hdr(skb)->protocol == IPPROTO_UDP) ? 1U : 0U;
> +
> +		if (ip_hdr(skb)->version == 4) {
> +			dx_buff->is_tcp_cso =
> +				(ip_hdr(skb)->protocol == IPPROTO_TCP) ?
> +					1U : 0U;
> +			dx_buff->is_udp_cso =
> +				(ip_hdr(skb)->protocol == IPPROTO_UDP) ?
> +					1U : 0U;
> +		} else if (ip_hdr(skb)->version == 6) {
> +			dx_buff->is_tcp_cso =
> +				(ipv6_hdr(skb)->nexthdr == NEXTHDR_TCP) ?
> +					1U : 0U;
> +			dx_buff->is_udp_cso =
> +				(ipv6_hdr(skb)->nexthdr == NEXTHDR_UDP) ?
> +					1U : 0U;
> +		}
>  	}
>  
>  	for (; nr_frags--; ++frag_count) {
> 

Fixes tcp/ipv6

Tested-by: David Arcari <darcari@...hat.com>