netdev - Re: [patch net-next] net: sched: choke: remove dead filter classify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Mar 2017 12:47:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, mlxsw@...lanox.com
Subject: Re: [patch net-next] net: sched: choke: remove dead filter
 classify code

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 23 Mar 2017 17:02:16 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> sch_choke is classless qdisc so it does not define cl_ops. Therefore
> filter_list cannot be ever changed, being NULL all the time.
> Reason is this check in tc_ctl_tfilter:
> 
> 	/* Is it classful? */
> 	cops = q->ops->cl_ops;
> 	if (!cops)
> 		return -EINVAL;
> 
> So remove this dead code.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thanks Jiri.