netdev - Re: [PATCH net] secure_seq: downgrade to per-host timestamp offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Mar 2017 19:28:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, soheil@...gle.com, edumazet@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] secure_seq: downgrade to per-host timestamp offsets

From: Florian Westphal <fw@...len.de>
Date: Fri, 24 Mar 2017 19:42:37 +0100

> Unfortunately too many devices (not under our control) use tcp_tw_recycle=1,
> which depends on timestamps being identical of the same saddr.
> 
> Although tcp_tw_recycle got removed in net-next we can't make
> such end hosts disappear so downgrade to per-host timestamp offsets.
> 
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>
> Reported-by: Yvan Vanrossomme <yvan@...rossomme.net>
> Fixes: 95a22caee396c ("tcp: randomize tcp timestamp offsets for each connection")
> Signed-off-by: Florian Westphal <fw@...len.de>

Ok, applied and queued up for -stable.

> David, I can cook a stable patch using jhash if needed, just let me know
> (siphash was added after 4.10).

Yes, I'll need that, thanks!