netdev - Re: [PATCH 5/5] PCI: remove pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2017 19:11:48 +0200
From:   Christoph Hellwig <hch@....de>
To:     David Daney <ddaney.cavm@...il.com>
Cc:     Christoph Hellwig <hch@....de>, bhelgaas@...gle.com,
        davem@...emloft.net, netanel@...apurnalabs.com, jcliburn@...il.com,
        chris.snook@...il.com, sgoutham@...ium.com, rric@...nel.org,
        netdev@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 5/5] PCI: remove pci_enable_msix

On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote:
> On 03/27/2017 01:29 AM, Christoph Hellwig wrote:
>> Unused now that all callers switched to pci_alloc_irq_vectors.
>>
>
> And you are aware that the ThunderX GPIO driver that I am attempting to 
> merge uses this interface.
>
> If this patch gets merged, should I ask to revert it when the GPIO driver 
> goes in?

No.  You should not use pci_enable_msix in your new driver as I told
you before.

> You offer no solution for drivers that would benefit from using a sparse 
> sub set of the available MSI-X vectors.

Use pci_enable_msix_{exact,range} for now, as I told you before.