netdev - Re: [PATCH V8 1/3] irq: Add flags to request_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2017 10:44:42 +0200
From:   Andrew Jones <drjones@...hat.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        peterz@...radead.org, nicolas.pitre@...aro.org, rafael@...nel.org,
        vincent.guittot@...aro.org, linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        xen-devel@...ts.xenproject.org, kernel@...inux.com,
        linux-samsung-soc@...r.kernel.org, netdev@...r.kernel.org,
        kvmarm@...ts.cs.columbia.edu, kvm@...r.kernel.org
Subject: Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote:
> diff --git a/drivers/clocksource/timer-nps.c b/drivers/clocksource/timer-nps.c
> index da1f798..dbdb622 100644
> --- a/drivers/clocksource/timer-nps.c
> +++ b/drivers/clocksource/timer-nps.c
> @@ -256,7 +256,7 @@ static int __init nps_setup_clockevent(struct device_node *node)
>  		return ret;
>  
>  	/* Needs apriori irq_set_percpu_devid() done in intc map function */
> -	ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler,
> +	ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler, IRQF_TIMER,
>  				 "Timer0 (per-cpu-tick)",
>  				 &nps_clockevent_device);

Wrong parameter order here.

drew