lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Mar 2017 15:03:30 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Christoph Hellwig' <hch@....de> CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>, "netanel@...apurnalabs.com" <netanel@...apurnalabs.com>, "jcliburn@...il.com" <jcliburn@...il.com>, "chris.snook@...il.com" <chris.snook@...il.com>, "sgoutham@...ium.com" <sgoutham@...ium.com>, "rric@...nel.org" <rric@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org> Subject: RE: [PATCH 5/5] PCI: remove pci_enable_msix From: 'Christoph Hellwig' > Sent: 27 March 2017 15:52 > On Mon, Mar 27, 2017 at 02:06:45PM +0000, David Laight wrote: > > Apart from all the 'out of tree' drivers that will need > > fixing and a conditional compile added. > > That has never been a reason for stopping linux kernel changes. I'm aware of that, but sometimes you just make life hard. > Never mind that your out of tree drivers should probably never have used > this function anyway, but pci_enable_msix_{exact,range} which would have > been the better choice even before pci_alloc_irq_vectors. Indeed, but pci_enable_msix_range() only appeared in 3.14. We have to support a wide range of kernels. I think we've finally managed to get most of our customers off 2.6.18. David
Powered by blists - more mailing lists