netdev - Re: [PATCH] 6lowpan: fix assignment of peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2017 16:32:37 +0300
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 6lowpan: fix assignment of peer_addr

Hi Colin,

On Tue, Mar 28, 2017 at 3:11 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  net/bluetooth/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 24348c8579dd..ba28c7b1557f 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
>                 }
>
>                 daddr = peer->lladdr;
> -               peer_addr = &peer->chan->dst;
> +               *peer_addr = peer->chan->dst;
>                 *peer_addr_type = peer->chan->dst_type;
>                 lowpan_cb(skb)->chan = peer->chan;
>
> --
> 2.11.0

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>

-- 
Luiz Augusto von Dentz