netdev - Re: [PATCH] 6lowpan: set peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2017 15:37:00 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Stefan Schmidt <stefan@....samsung.com>,
        Jukka Rissanen <jukka.rissanen@...ux.intel.com>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Patrik Flykt <patrik.flykt@...ux.intel.com>,
        Alexander Aring <aar@...gutronix.de>,
        Glenn Ruben Bakke <glennrubenbakke@...dicsemi.no>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 6lowpan: set peer_addr correctly again

Hi Arnd,

> A bugfix accidentally changed one line to return the peer_addr
> from setup_header, causing it to become unused:
> 
> net/bluetooth/6lowpan.c: In function 'setup_header':
> net/bluetooth/6lowpan.c:402:14: error: parameter 'peer_addr' set but not used [-Werror=unused-but-set-parameter]
> 
> The only user of the variable is a subsequent printk(), and
> it is not otherwise initialized, so reverting the changed line
> looks like the right fix.
> 
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I took Colin’s patch since it showed up first in my inbox.

Regards

Marcel