netdev - Re: [REGRESSION] mac80211: IBSS vif queue stopped when started after 11s vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2017 14:11:08 +0200
From:   Sven Eckelmann <sven.eckelmann@...nmesh.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Michal Kazior <michal.kazior@...to.com>
Subject: Re: [REGRESSION] mac80211: IBSS vif queue stopped when started after 11s vif

On Mittwoch, 29. März 2017 13:53:06 CEST Johannes Berg wrote:
[...]
> > Not sure whether removing it in ieee80211_propagate_queue_wake will
> > have other odd side effects with software queuing. Maybe Michal
> > Kazior can tell us if it is safe to remove it.
> 
> No, it's the other way around.
> 
> Michal's patches correctly added a test for this to
> __ieee80211_stop_queue(), the only missing thing is that this test
> should also be in ieee80211_do_open() like this:
> 
> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
> index 40813dd3301c..5bb0c5012819 100644
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -718,7 +718,8 @@ int ieee80211_do_open(struct wireless_dev *wdev, bool coming_up)
>  	ieee80211_recalc_ps(local);
>  
>  	if (sdata->vif.type == NL80211_IFTYPE_MONITOR ||
> -	    sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
> +	    sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||
> +	    local->ops->wake_tx_queue) {
>  		/* XXX: for AP_VLAN, actually track AP queues */
>  		netif_tx_start_all_queues(dev);
>  	} else if (dev) {

Yes, this also works.

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)