netdev - Re: [PATCH net] ftgmac100: Mostly rewrite the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 01:42:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [PATCH net] ftgmac100: Mostly rewrite the driver

Hi Benjamin,

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/ftgmac100-Mostly-rewrite-the-driver/20170329-155424
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/faraday/ftgmac100.c: In function 'ftgmac100_netpoll':
>> drivers/net/ethernet/faraday/ftgmac100.c:1277:14: error: 'dev' undeclared (first use in this function)
     disable_irq(dev->irq);
                 ^~~
   drivers/net/ethernet/faraday/ftgmac100.c:1277:14: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/ethernet/faraday/ftgmac100.c: At top level:
>> drivers/net/ethernet/faraday/ftgmac100.c:1295:25: error: 'ftgmac100_poll_controller' undeclared here (not in a function)
     .ndo_poll_controller = ftgmac100_poll_controller,
                            ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/faraday/ftgmac100.c:1273:13: warning: 'ftgmac100_netpoll' defined but not used [-Wunused-function]
    static void ftgmac100_netpoll(struct net_device *ndev)
                ^~~~~~~~~~~~~~~~~

vim +/dev +1277 drivers/net/ethernet/faraday/ftgmac100.c

  1271	
  1272	#ifdef CONFIG_NET_POLL_CONTROLLER
  1273	static void ftgmac100_netpoll(struct net_device *ndev)
  1274	{
  1275		unsigned long flags;
  1276	
> 1277		disable_irq(dev->irq);
  1278		local_irq_save(flags);
  1279		ftgmac100_interrupt(dev->irq, ndev);
  1280		local_irq_restore(flags);
  1281		enable_irq(dev->irq);
  1282	}
  1283	#endif
  1284	
  1285	static const struct net_device_ops ftgmac100_netdev_ops = {
  1286		.ndo_open		= ftgmac100_open,
  1287		.ndo_stop		= ftgmac100_stop,
  1288		.ndo_start_xmit		= ftgmac100_hard_start_xmit,
  1289		.ndo_set_mac_address	= ftgmac100_set_mac_addr,
  1290		.ndo_set_rx_mode	= ftgmac100_set_rx_mode,
  1291		.ndo_validate_addr	= eth_validate_addr,
  1292		.ndo_do_ioctl		= ftgmac100_do_ioctl,
  1293		.ndo_tx_timeout		= ftgmac100_tx_timeout,
  1294	#ifdef CONFIG_NET_POLL_CONTROLLER
> 1295		.ndo_poll_controller	= ftgmac100_poll_controller,
  1296	#endif
  1297	};
  1298	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (61365 bytes)