netdev - Re: [PATCH net-next 1/1] net: tcp: Define the TCP_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 09:36:57 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Gao Feng <gfree.wind@...mail.com>
Cc:     David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Patrick McHardy <kaber@...sh.net>,
        Netdev <netdev@...r.kernel.org>, Gao Feng <fgao@...ai8.com>
Subject: Re: [PATCH net-next 1/1] net: tcp: Define the TCP_MAX_WSCALE instead
 of literal number 14

On Mon, Apr 3, 2017 at 9:26 AM, Gao Feng <gfree.wind@...mail.com> wrote:
>>
>> Looks OK to me.
>>
>> IMHO this is a nice direction, since there is a proposal to increase the maximum
>> shift factor from 14 to 15:
>>   https://tools.ietf.org/html/draft-nishida-tcpm-maxwin-03
>
> Do you mean enlarge the wscale to 15 now ?

No, I just meant that it will be easier to change if we ever decide to
change this to 15.


>> Though there are a few spots where a literal 14 appears:
>>
>> tcp_input.c:3763:  net_info_ratelimited("%s: Illegal window scaling
>> value %d >14 received\n",
>>
>> tcp_output.c:238:                * See RFC1323 for an explanation of
>> the limit to 14
>
> Ok, I will update these two spots.

OK, thanks.

neal