netdev - Re: [PATCH] soreuseport: use "unsigned int" in __reuseport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 03 Apr 2017 19:06:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     adobriyan@...il.com
Cc:     netdev@...r.kernel.org, kraig@...gle.com
Subject: Re: [PATCH] soreuseport: use "unsigned int" in __reuseport_alloc()

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Mon, 3 Apr 2017 01:18:23 +0300

> Number of sockets is limited by 16-bit, so 64-bit allocation will never
> happen.
> 
> 16-bit ops are the worst code density-wise on x86_64 because of
> additional prefix (66).
> 
> Space savings:
> 
> 	add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
> 	function                                     old     new   delta
> 	reuseport_add_sock                           539     536      -3
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Applied.