netdev - Re: [PATCH 2/4] net: stmmac: adding multiple buffers for rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2017 21:23:18 +0200
From:   Thierry Reding <treding@...dia.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
CC:     <davem@...emloft.net>, <clabbe.montjoie@...il.com>,
        <niklas.cassel@...s.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4] net: stmmac: adding multiple buffers for rx

On Tue, Apr 04, 2017 at 06:54:25PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> @@ -3402,6 +3474,9 @@ static irqreturn_t stmmac_interrupt(int irq, void *dev_id)
>  
>  		if (priv->synopsys_id >= DWMAC_CORE_4_00) {
>  			for (queue = 0; queue < queues_count; queue++) {
> +				struct stmmac_rx_queue *rx_q =
> +				&priv->rx_queue[queue];

Found one more: the indentation here looks wrong. I think it's more
idiomatic to indent by at least a tab in such cases.

> +
>  				status |=
>  				priv->hw->mac->host_mtl_irq_status(priv->hw,
>  								   queue);

This is becoming quite unwieldy because of the indentation levels. Maybe
this could be split out into a separate function. Could be a separate
patch, though.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)